schmalz/shared-actions
15
0
Fork 0
Code Issues Pull requests 1 Releases Packages Activity Actions

feat: add per-file cache_rules and fix argument escaping #32

Merged
Michael.Seele merged 1 commit from feature/publish-static-contents-cache-rules into main 2026-05-22 05:09:48 +00:00
Conversation 2 Commits 1 Files changed 2 +83 -26
Michael.Seele commented 2026-05-21 15:49:05 +00:00
Owner
Copy link
  • Add cache_rules input: JSON array of per-file cache overrides, each uploaded individually with its own Cache-Control and Content-Type headers and excluded from the bulk sync
  • When versioning is true and cache_rules is empty, auto short-cache index.html (no-cache, max-age=300) if it exists in dist_dir
  • Fix EXCLUDE_ARGS and CT_ARG to use bash arrays for correct handling of filenames and content-type values containing spaces
- Add cache_rules input: JSON array of per-file cache overrides, each uploaded individually with its own Cache-Control and Content-Type headers and excluded from the bulk sync - When versioning is true and cache_rules is empty, auto short-cache index.html (no-cache, max-age=300) if it exists in dist_dir - Fix EXCLUDE_ARGS and CT_ARG to use bash arrays for correct handling of filenames and content-type values containing spaces
Michael.Seele added 1 commit 2026-05-21 15:49:05 +00:00
feat: add per-file cache_rules and fix argument escaping
All checks were successful
validate-shared-actions / validate-shared-actions (pull_request) Successful in 41s
Details
Aikido Security PR Check / Aikido Security Scan (pull_request) Successful in 1m47s
Details
1a4e26705d 
- Add cache_rules input: JSON array of per-file cache overrides, each uploaded individually with its own Cache-Control and Content-Type headers and excluded from the bulk sync
- When versioning is true and cache_rules is empty, auto short-cache index.html (no-cache, max-age=300) if it exists in dist_dir
- Fix EXCLUDE_ARGS and CT_ARG to use bash arrays for correct handling of filenames and content-type values containing spaces
requested review from Developers 2026-05-21 15:49:06 +00:00
Sebastian.Boehringer approved these changes 2026-05-22 04:54:11 +00:00
Dismissed
publish-static-contents/action.yml Outdated
@ -68,1 +96,4 @@
# Bulk sync remaining files; versioned builds get immutable cache headers
CACHE_CONTROL_ARG=""
[[ "${INPUT_VERSIONING}" == "true" ]] && CACHE_CONTROL_ARG="--cache-control 'public, max-age=31536000, immutable'"
Sebastian.Boehringer commented 2026-05-22 04:50:24 +00:00
Owner
Copy link

Persönlich finde ich es leichter zu verstehen, wenn das hier auch in einem if gesetzt wird anstatt auf das verhalten von && zu setzen.

Persönlich finde ich es leichter zu verstehen, wenn das hier auch in einem if gesetzt wird anstatt auf das verhalten von && zu setzen.
Michael.Seele commented 2026-05-22 05:05:11 +00:00
Author
Owner
Copy link

Sehe ich auch so. Vor allem ist es dann einheitlich. Wird noch verbessert...

Sehe ich auch so. Vor allem ist es dann einheitlich. Wird noch verbessert...
Michael.Seele marked this conversation as resolved
Michael.Seele force-pushed feature/publish-static-contents-cache-rules from 1a4e26705d to c690178858 2026-05-22 05:06:52 +00:00 Compare
Michael.Seele dismissed Sebastian.Boehringer's review 2026-05-22 05:06:52 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Sebastian.Boehringer approved these changes 2026-05-22 05:08:40 +00:00
Michael.Seele merged commit 97d17f46e8 into main 2026-05-22 05:09:48 +00:00
Michael.Seele deleted branch feature/publish-static-contents-cache-rules 2026-05-22 05:09:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Sebastian.Boehringer
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: schmalz/shared-actions#32
No description provided.
Delete branch "feature/publish-static-contents-cache-rules"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?